New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let user specify how many rows will be displayed in Scheduled Reports. #6607
Let user specify how many rows will be displayed in Scheduled Reports. #6607
Conversation
We really need to find a way to let plugins configure things without having to edit Of course having everything in one config file is nice for the users. Maybe plugins could also provide their own "global.ini.php" which could be merged somehow with our "global.ini.php". "somehow" :) Or something similar... |
Settings API sounds very good for me! I'll try to write some code to solve this and attach to this PR, so please, hold with merging. :) |
; scheduled reports truncate limit | ||
; the report will be rendered with the first 23 rows and will aggregate other rows in a summary row | ||
; 23 rows table fits in one portrait page | ||
schedule_reports_truncate = 23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be scheduled
@czolnowski thomas created issue at #6609 but you don't need to solve it now, let's stay focused on this small feature for this PR |
Hacks / adding dependencies shouldn't be justified just because it is a small feature. Then we'll always have this mess ;) And using Settings API should be easy to use |
@tsteur of course I agree that we should find better solution directly, but here we have already done this before (see setting |
@mattab: I have renamed this config parameter according to your guidelines. |
Cheers! fyi it's not 'my' guideline but it's to be consistent with existing setting just above in the file |
…ncate-limit-into-config Let user specify how many rows will be displayed in Scheduled Reports.
I have simply change const into config value and describe them in global.ini.php