New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to benchmark either a PHPUnit test case w/ custom Piwik related code or Piwik URL #6603
Conversation
…ommand class (for reuse in another command).
…y, but nothing else.
…files to EC2 instance).
…:benchmark related code.
@@ -130,7 +130,7 @@ before_script: | |||
- ./tests/travis/prepare.sh | |||
- ./tests/travis/setup_webserver.sh | |||
|
|||
- export GENERATE_TRAVIS_YML_COMMAND="php ./console generate:travis-yml --core" | |||
- export GENERATE_TRAVIS_YML_COMMAND="php ./console --core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that normal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so not normal.. whoops
What is the use case? Is it to run the same piece of code several time to profile it with xhprof? Or is it to measure the execution time of a piece of code? If it's the latter, what do we compare the execute time to? |
…point /home) - Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Hi @diosmosis - is it pending some work or ready to be reviewed and merged? |
@mattab Not done yet, needs some more work. |
Thank you for this proposed pull request. Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit). We hope you understand this and we look forward to seeing an update from you on this pull request or another one! Thanks. |
As title, new command
tests:benchmark
will load a fixture into the DB (specified through command line arguments and can be your own custom file) and then benchmark either a phpunit test case or URL. The phpunit test case can be your own custom test case (so you can benchmark any bit of Piwik code). Benchmarking can be done on AWS as well as locally.Includes some refactorings to CliMulti/RequestCommand/RunTestsOnAws/GenerateTravisYmlFile.
CC @mattab @mnapoli @tsteur Reviews welcome.