Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to benchmark either a PHPUnit test case w/ custom Piwik related code or Piwik URL #6603

Closed
wants to merge 10 commits into from

Conversation

diosmosis
Copy link
Member

As title, new command tests:benchmark will load a fixture into the DB (specified through command line arguments and can be your own custom file) and then benchmark either a phpunit test case or URL. The phpunit test case can be your own custom test case (so you can benchmark any bit of Piwik code). Benchmarking can be done on AWS as well as locally.

Includes some refactorings to CliMulti/RequestCommand/RunTestsOnAws/GenerateTravisYmlFile.

CC @mattab @mnapoli @tsteur Reviews welcome.

@@ -130,7 +130,7 @@ before_script:
- ./tests/travis/prepare.sh
- ./tests/travis/setup_webserver.sh

- export GENERATE_TRAVIS_YML_COMMAND="php ./console generate:travis-yml --core"
- export GENERATE_TRAVIS_YML_COMMAND="php ./console --core"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that normal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so not normal.. whoops

@mnapoli
Copy link
Contributor

mnapoli commented Nov 5, 2014

What is the use case? Is it to run the same piece of code several time to profile it with xhprof? Or is it to measure the execution time of a piece of code? If it's the latter, what do we compare the execute time to?

mnapoli referenced this pull request Nov 6, 2014
…point /home) - Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 7, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Nov 7, 2014
@mattab
Copy link
Member

mattab commented Nov 28, 2014

Hi @diosmosis - is it pending some work or ready to be reviewed and merged?

@diosmosis
Copy link
Member Author

@mattab Not done yet, needs some more work.

@mattab mattab modified the milestones: Piwik 2.10.0 , Short term Dec 1, 2014
@mattab
Copy link
Member

mattab commented Jan 9, 2015

Thank you for this proposed pull request.

Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit).

We hope you understand this and we look forward to seeing an update from you on this pull request or another one!

Thanks.

@mattab mattab closed this Jan 9, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jan 9, 2015
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 16, 2015
@mattab mattab deleted the benchmarking_command branch September 22, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants