Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static width of 190px looks bad in 2 & 3 column layout with IPv6 displayed #6601

Closed
wants to merge 1 commit into from
Closed

Static width of 190px looks bad in 2 & 3 column layout with IPv6 displayed #6601

wants to merge 1 commit into from

Conversation

ITSecMedia
Copy link

use percent not static width

@ITSecMedia
Copy link
Author

Don't use fixed width in pixels

@mattab
Copy link
Member

mattab commented Nov 6, 2014

Thanks for the pull request! do you maybe can post a screenshot before/after?

@mattab
Copy link
Member

mattab commented Nov 6, 2014

does it maybe fix #4391 ?

@ITSecMedia
Copy link
Author

Hi Matthieu, sorry I patched my own version already. I think a relative value of 30% is perhaps a slightly better solution OR ... ( just show IPv6 instead of the real IPv6 value as I doubt that anybody is really interested in the naked value at all in the live window )

@mattab
Copy link
Member

mattab commented Nov 6, 2014

can you maybe paste screenshot showing After, where the problem is solved?

@mnapoli mnapoli changed the title static width of 190px looks shitty in 2 & 3 column layout for IPv6 ... Static width of 190px looks bad in 2 & 3 column layout with IPv6 displayed Nov 13, 2014
@mattab
Copy link
Member

mattab commented Nov 17, 2014

@ITSecMedia ping

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Nov 17, 2014
@mattab mattab modified the milestones: Piwik 2.11.0, Short term Nov 17, 2014
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 17, 2014
@ITSecMedia
Copy link
Author

Hi Matthieu, sorry for the late response. After update to the latest version I had to re-apply my local changes. That time I could make a screenshot. But it's easy to test the behavior of this change in Google Chrome developer tools. I don't want to post my Piwik screenshots public, you got any Email where I can send to? - Everything has to be responsive these days. Using fixed pixel width sizes are not optimal.

@mattab
Copy link
Member

mattab commented Dec 2, 2014

Thanks for the suggestion! I'll fix it in: #6301

@mattab mattab closed this Dec 2, 2014
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ITSecMedia @mattab