Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik 2.8 cannot be installed on PHP 5.3.3 #6595

Closed
mnapoli opened this issue Nov 4, 2014 · 2 comments
Closed

Piwik 2.8 cannot be installed on PHP 5.3.3 #6595

mnapoli opened this issue Nov 4, 2014 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Nov 4, 2014

As reported on a StackOverflow question, Piwik complains that PHP 5.3.3 is not greater than required PHP 5.3.3.

Here is the comparison function:

$piwik_minimumPHPVersion = '5.3.3';
$piwik_currentPHPVersion = PHP_VERSION;
$minimumPhpInvalid = version_compare($piwik_minimumPHPVersion, $piwik_currentPHPVersion) > 0;

version_compare will return 0 if both versions are equal, which explains it I guess. Easy fix would be to replace > by >=: I will do it soon.

@mnapoli mnapoli added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 4, 2014
@mnapoli mnapoli self-assigned this Nov 4, 2014
@mnapoli mnapoli added this to the Piwik 2.9.0 milestone Nov 4, 2014
@mnapoli mnapoli closed this as completed in 6c1a90f Nov 4, 2014
mnapoli added a commit that referenced this issue Nov 5, 2014
@peterbo
Copy link
Contributor

peterbo commented Nov 12, 2014

Why was this reverted?

@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 12, 2014

Because I thought it was this bit of code but it wasn't ;) It was actually fixed in f5c50e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants