Customize privacy options on installation #6581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious Piwik installs, a migration script disable it on upgrade to 2.9.
…an enrich The PrivacyManager plugins adds 2 settings to that form to let user disable (enabled by default) DoNotTrack and IP anonymization
mnapoli
added
Pull Request WIP
| @@ -2,6 +2,7 @@ | |||
| "PrivacyManager": { | |||
| "AnonymizeIpDescription": "Select \"Yes\" if you want Piwik not to track fully qualified IP-Addresses.", | |||
| "AnonymizeIpInlineHelp": "Anonymize the last byte(s) of visitors IP addresses to comply with your local privacy laws\/guidelines.", | |||
| "AnonymizeIpExtendedHelp": "When users visit your website, Piwik will not use the full IP address (such as 213.34.51.91) but instead Piwik will anonymise it first (to 213.34.0.0). IP address anonymisation is one of the requirements set by the privacy laws in some countries such as Germany.", | |||
There was a problem hiding this comment.
Here you could maybe replace 213.34.51.91 and 213.34.0.0 by %1$s and %2$s and sprintf the values so translators cannot make typos
nice idea 👍 PR looks good to me! |
| } | ||
|
|
||
| $view->addForm($form); | ||
|
|
There was a problem hiding this comment.
Should I add Piwik::checkUserHasSuperUserAccess(); in this installation step? Because it doesn't do $this->checkPiwikIsNotInstalled(); like in the other steps, so I guess anybody can go to this step?
…dy installed The last step is now also not optional, you need to visit the page to mark installation as finished
mattab
pushed a commit
that referenced
this pull request
Nov 3, 2014
Customize privacy options on installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5052 and #6566 (as well as #6579 which is included in the first one).
It contains an update script for 2.9 that will disable IP anonymization if it wasn't configured before. The reason is that we change from "disabled by default" to "enabled by default", so we don't want to enable it on previous Piwik installs.
It also adds a new form in the last installation step. This form is dynamic and constructed with events so that there is no explicit mention of other plugins (as suggested by @tsteur), that means that plugins can add their own field here (but I guess it shouldn't be abused).
The form shows the default settings. The user can then submit the form which will saves his settings in the database. If he refreshes Piwik to get to the homepage somehow, then he will still use the default settings so all is good ("do not track" and "IP anonymization" are enabled by default).
Please review as it affects upgrade and installation, and I guess we really don't want to break those parts ;)