Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for running ./console with php-cgi by setting SERVER args from GET parameters. #6570

Closed
wants to merge 2 commits into from

Conversation

diosmosis
Copy link
Member

As title. Tested php-cgi ./console list, php-cgi ./console help tests:run, php-cgi ./console test:run Core_OptionsTest and php-cgi ./console core:archive --url=localhost. No output received on last one, but logs show archiving succeeded.

What do you think @tsteur?

CC @mattab

@diosmosis diosmosis changed the title Add compatibility to ./console with php-cgi by setting SERVER args from GET parameters. Add compatibility for running ./console with php-cgi by setting SERVER args from GET parameters. Nov 1, 2014
@tsteur
Copy link
Member

tsteur commented Nov 2, 2014

I implemented something similar a while ago and didn't commit as there were more issues I think but don't remember which ones. Maybe it was the problem with input/output.

If input / output doesn't work I'd probably still prefer to leave the previous check and do not allow usage of CGI with Console as people might think it is broken etc. Some commands ask for input and it would just not work for them. Also not getting output might be annoying especially when there is an error.

…onsole run with php-cgi & make sure cronarchive log config changes are used even if Log singleton created already.
@diosmosis
Copy link
Member Author

I got input from stdin to work, (tested w/ php-cgi generate:plugin). The lack of output for core:archive was due to CronArchive.php bug. Can you think of anything else to test @tsteur ?

@tsteur
Copy link
Member

tsteur commented Nov 2, 2014

I looked for the Symfony page re CGI support but can't find it anymore. Was hoping to find some more infos re possible issues there. As I said I don't remember which problems I ran into that time... :(

@mattab
Copy link
Member

mattab commented Nov 2, 2014

Hi @diosmosis since you seem to have tested all use cases for console, it looks good to me to add it & wait for user feedback!
some 1&1 users don't have CLI and only CGI so hopefully this does the trick for them 👍

@diosmosis diosmosis closed this Nov 3, 2014
@diosmosis diosmosis deleted the phpcgi_console_compat branch November 3, 2014 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants