@diosmosis opened this Pull Request on October 31st 2014 Member

As title. Tested php-cgi ./console list, php-cgi ./console help tests:run, php-cgi ./console test:run Core_OptionsTest and php-cgi ./console core:archive --url=localhost. No output received on last one, but logs show archiving succeeded.

What do you think @tsteur?

CC @mattab

@tsteur commented on November 2nd 2014 Member

I implemented something similar a while ago and didn't commit as there were more issues I think but don't remember which ones. Maybe it was the problem with input/output.

If input / output doesn't work I'd probably still prefer to leave the previous check and do not allow usage of CGI with Console as people might think it is broken etc. Some commands ask for input and it would just not work for them. Also not getting output might be annoying especially when there is an error.

@diosmosis commented on November 2nd 2014 Member

I got input from stdin to work, (tested w/ php-cgi generate:plugin). The lack of output for core:archive was due to CronArchive.php bug. Can you think of anything else to test @tsteur ?

@tsteur commented on November 2nd 2014 Member

I looked for the Symfony page re CGI support but can't find it anymore. Was hoping to find some more infos re possible issues there. As I said I don't remember which problems I ran into that time... :(

@mattab commented on November 2nd 2014 Member

Hi @diosmosis since you seem to have tested all use cases for console, it looks good to me to add it & wait for user feedback!
some 1&1 users don't have CLI and only CGI so hopefully this does the trick for them :+1:

This Pull Request was closed on November 3rd 2014
Powered by GitHub Issue Mirror