Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate reports from UserSettings plugin #6565

Merged
merged 57 commits into from Nov 26, 2014
Merged

Remove duplicate reports from UserSettings plugin #6565

merged 57 commits into from Nov 26, 2014

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 30, 2014

Target of this PR is to remove all duplicate reports from UserSettings plugin and migrate their data to DevicesDetection plugin (refs #3962)

What needs to be done:

  • forward API calls from UserSettings to DevicesDetection plugin & depreacte those API mehtods
  • Remove duplicate Reports from UserSettings Plugin
  • Update-Script:
    • Rename all UserSettings-Blobs to DevicesDetection-Blobs where possible
    • Migrate / Regenerate missing Blobs (Browser + OS w/ version)
    • replace widgets in existing dashboards
    • replace reports in scheduled reports
  • CleanUp UserSettings Plugin
    • remove now unused Rows
    • remove unused helper functions
    • remove archiving for removed reports
  • remove UserAgentParser as soon as it is unused
  • Cechk backward compatibility
    • deprecated UserSettings API calls should still work
    • deprecated UserSettings widgetize URLs should display or redirect to new reports instead
  • Cleanup translations (will be done after merging, to ensure master and oTrance are in sync)
  • update default dashboard to use new widget(s)
  • update changelog

@sgiehl
remove old usersettings tests as they are obsolete now; there are mor…
79c71c7 
…e than enough tests in device detector itself
@sgiehl
remove 'Extended' from function names
f9ba253
@sgiehl
ensure device type report always contain all device types
e803319
@sgiehl
Remove MobileVSDesktop reports as we now have detailed device type re…
d34a876 
…ports; rename GetWideScreen report to GetScreenType, as that better points out what it returns
@sgiehl
extend browser and os details in devicesdetection plugin
dcf9565
@sgiehl
do no longer archive os and browser data in usersettings plugin
e29f107
@sgiehl
rename reports 'GetBrowserFamilies' to 'GetBrowsers' as families are …
e7cdc75 
…more like engines and not browsers without versions
@sgiehl
remove browser & os reports from usersettings plugin
390f825
@sgiehl
moved columns settings like segments to devicesdetection plugin and r…
d30c662 
…emoved them from usersettings plugin
@sgiehl
passthrough all calls to 'moved' API methods from usersettings plugin…
0332e8d 
… to devicesdetection plugin; marked those as deprecated
@sgiehl
cleaned up usersettings functions
dd4376b
@sgiehl
KABOOM - removed old UserAgentParser as it is not used anymore!
d62c15e
@sgiehl
enabled DevicesDetection plugin for OneVisitorTwoVisits_withCookieSup…
653bf01 
…port tests; updated expected test files
@sgiehl
updated a couple of test files
b41d73a
@sgiehl
updating some more tests
cb46475
@sgiehl
Merge branch 'master' into deprecate_usersettings
6f38b1a
@sgiehl
fixing rowevolution test
f6fa63f
@sgiehl
remove obsolete test files
9424aa4
@sgiehl
update test file
f171539
@sgiehl
update expected test files
6cb4014
@sgiehl
update expected test files
3d77d3f
@sgiehl
fix test
ae7ed3f
@sgiehl
Merge branch 'master' into deprecate_usersettings
407a665
@sgiehl
readded expected files for deprecated apis
261a60b
@sgiehl
fixed some tests
2903e59
@sgiehl
Merge branch 'master' into deprecate_usersettings
a4342fa
@sgiehl
Merge branch 'master' into deprecate_usersettings
0c97fc8
@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Oct 30, 2014
@sgiehl sgiehl self-assigned this Oct 30, 2014
@sgiehl
Copy link
Member Author

sgiehl commented Nov 15, 2014

I have decided to remove that os short labels completely. I don't think that they make any sense. There were around 15 short names defined, for the rest the long name was taken. DD currently detects > 60 os. So most of them would have been displayed in long.

@sgiehl
Merge branch 'master' into deprecate_usersettings
3878792 
Conflicts:
	tests/PHPUnit/System/expected/test_OneVisitor_NoKeywordSpecified__Live.getLastVisitsDetails_day.xml
@sgiehl
use ArchiveTableCreator to get blob tables
0d1d705
@sgiehl
refactored duplicate code
432a8c8
@sgiehl
fix version number
afb283a
@sgiehl
map removed usersettings reports to new reports in devicesdetection p…
47cbb9a 
…lugin to make existing widgetize urls still working
@sgiehl
use devicesdetection widget in default dashboard instead of deprecate…
6dd9a92 
…d usersettings widget
@sgiehl
Merge branch 'master' into deprecate_usersettings
6c62004
@sgiehl
added sqls for updating scheduled reports to new devicesdetection rep…
802eb98 
…otrs
@sgiehl
added update sql to update existing dashboards to use new widgets (if…
26188f9 
… they are not already placed on it)
@mattab
Copy link
Member

mattab commented Nov 22, 2014

I have decided to remove that os short labels completely.

+1 - we'll get to see in the screenshot tests all places that this impacts... also maybe static graphs in scheduled reports? either way, a good decision!

@sgiehl
Copy link
Member Author

sgiehl commented Nov 24, 2014

I'm done so far. Will do a translation cleanup after the merge.
@mattab could you do a last review? Feel free to merge if there's nothing wrong anymore

@sgiehl sgiehl added this to the Piwik 2.10.0 milestone Nov 24, 2014
@mattab
Copy link
Member

mattab commented Nov 26, 2014

Nice streak... i'm merging! and going to run some tests on demo2

mattab pushed a commit that referenced this pull request Nov 26, 2014
Merge pull request #6565 from piwik/deprecate_usersettings
61a7032 
Remove duplicate reports from UserSettings plugin refs #3962
@mattab mattab merged commit 61a7032 into master Nov 26, 2014
mattab added a commit that referenced this pull request Nov 26, 2014
@mattab
Simplified widget selection, removed duplicate UserSettings<>DeviceDe…
aef0e89 
…tection widgets and some other change now that we use Device Detector data #6565 #3962
@mattab mattab deleted the deprecate_usersettings branch December 16, 2014 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgiehl sgiehl

Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab