@sgiehl opened this Pull Request on October 30th 2014 Member

Target of this PR is to remove all duplicate reports from UserSettings plugin and migrate their data to DevicesDetection plugin (refs #3962)

What needs to be done:

  • [x] forward API calls from UserSettings to DevicesDetection plugin & depreacte those API mehtods
  • [x] Remove duplicate Reports from UserSettings Plugin
  • [x] Update-Script:
    • [x] Rename all UserSettings-Blobs to DevicesDetection-Blobs where possible
    • [x] Migrate / Regenerate missing Blobs (Browser + OS w/ version)
    • [x] replace widgets in existing dashboards
    • [x] replace reports in scheduled reports
  • [x] CleanUp UserSettings Plugin
    • [x] remove now unused Rows
    • [x] remove unused helper functions
    • [x] remove archiving for removed reports
  • [x] remove UserAgentParser as soon as it is unused
  • [x] Cechk backward compatibility
    • [x] deprecated UserSettings API calls should still work
    • [x] deprecated UserSettings widgetize URLs should display or redirect to new reports instead
  • [x] Cleanup translations (will be done after merging, to ensure master and oTrance are in sync)
  • [x] update default dashboard to use new widget(s)
  • [x] update changelog
@sgiehl commented on November 13th 2014 Member

@mattab would you mind having a look at the update script. Maybe there's an better/easier way to handle that

@mattab commented on November 15th 2014 Member

excellent change, working out some good technical debt.

Regarding the upgrade script, it's useful to return all the SQL to execute in the getSql() call, as admins will look at the SQL queries and then execute it manually.

Regarding backward compatibility could you check to maintain it:

@sgiehl commented on November 15th 2014 Member

I have decided to remove that os short labels completely. I don't think that they make any sense. There were around 15 short names defined, for the rest the long name was taken. DD currently detects > 60 os. So most of them would have been displayed in long.

@mattab commented on November 22nd 2014 Member

I have decided to remove that os short labels completely.

+1 - we'll get to see in the screenshot tests all places that this impacts... also maybe static graphs in scheduled reports? either way, a good decision!

@sgiehl commented on November 24th 2014 Member

I'm done so far. Will do a translation cleanup after the merge.
@mattab could you do a last review? Feel free to merge if there's nothing wrong anymore

@mattab commented on November 26th 2014 Member

Nice streak... i'm merging! and going to run some tests on demo2

This Pull Request was closed on November 26th 2014
Powered by GitHub Issue Mirror