Support for importing AWS CloudFront log files #6554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
changed the title
mnapoli
added
the
Enhancement
|
Thanks for the PR! This is nice new feature. Would you mind adding test log file in the |
mattab
added
the
Pull Request WIP
… with success. Test reported: 14:46:51 $ ./run_tests.sh ...................................... ---------------------------------------------------------------------- Ran 38 tests in 0.024s OK
|
Hi Mattab, I have added the cloudfront log file and modified tests.py to support test for cloudfront logs. The test reported OK. Thank you, |
added 2 commits
December 1, 2014 14:51
…ave re-added it now.
Run the test again and it is working.
| @@ -254,6 +259,7 @@ def check_format(self, file): | |||
| 'common_complete': RegexFormat('common_complete', _HOST_PREFIX + _NCSA_EXTENDED_LOG_FORMAT), | |||
| 'iis': IisFormat(), | |||
| 's3': RegexFormat('s3', _S3_LOG_FORMAT), | |||
| 'cdn': RegexFormat('cdn', _CDN_LOG_FORMAT, '%Y-%m-%d %H:%M:%S'), | |||
There was a problem hiding this comment.
could you rename cdn to amazon_cloudfront ?
|
Fixed in #6851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support to allow import of Amazon CloudFront log files. It has been tested and it is working fine.