Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine the unit tests went from 20 seconds to 5 seconds! (with several plugins installed)
I've done some profiling to see where we have some room for improvements:
sleep()
in the tests and replaced with something else--no-globals-backup
: globals backup by PHPUnit was the most expensive operation in all the test runphp -n
About
--no-globals-backup
: unit tests should obviously not mess with global variables, so there shouldn't be any problem in theory. However there are some tests that do change the global variables, so for each of these tests I've used the@backupGlobals enabled
annotation.E.g. you can use this command line:
Or you can also setup PhpStorm by setting
--testsuite UnitTests --no-globals-backup
in the "Test Runner options" and-n
in "Interpreter options".