Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated test to detect whether a Plugin follows distribution best practises #6543

Closed
mattab opened this issue Oct 28, 2014 · 4 comments
Closed

Automated test to detect whether a Plugin follows distribution best practises #6543

mattab opened this issue Oct 28, 2014 · 4 comments
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Oct 28, 2014

The goal of this issue is to create a new automated test that runs in each Plugin's CI build, that will help a plugin developer implement best practises in his plugin.

Ideas of best practises to check for:

  • The repository should have some tests,
  • The README should have the section Description, Changelog, Support,
  • The plugin should have a screenshot (so it looks good on marketplace),
  • The plugin.json license, authors, should be consistent for Piwik and Piwik PRO plugins,
  • Notifications to Slack should be enabled,
  • Other ideas?

Reference: distribute your plugin on the Marketplace.
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 28, 2014
@mattab mattab added this to the Mid term milestone Oct 28, 2014
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 28, 2014
@mnapoli
Copy link
Contributor

mnapoli commented Oct 28, 2014

Notifications to Slack should be enabled

Notifications about builds? I'm not sure this is a good idea, even with piwik and ui-tests the amount of notifications makes it near useless.

@mattab
Copy link
Member Author

mattab commented Oct 28, 2014

Notifications about builds?

I meant git push notifications as it's quite nice to see all commits in the channel. You're right that travis build notifications is too noisy in slack.

@mnapoli
Copy link
Contributor

mnapoli commented Oct 28, 2014

Oh ok even more noisy, I'll be out of this channel ;)

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab
Copy link
Member Author

mattab commented Jan 2, 2017

Not needed anymore

@mattab mattab closed this as completed Jan 2, 2017
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @mnapoli