Use exceptions instead of calls to Piwik_ExitWithMessage #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 27, 2014 20:46
…exceptions & include HtmlMessageException class for exceptions w/ HTML content in their message.
diosmosis
force-pushed
the
remove_exitwithmessage
branch
from
5b62c02
to
cdb7ed2
Compare
| @@ -81,7 +81,7 @@ public static function getDatabaseConfig($dbConfig = null) | |||
| */ | |||
| Piwik::postEvent('Db.getDatabaseConfig', array(&$dbConfig)); | |||
|
|
|||
| $dbConfig['profiler'] = $config->Debug['enable_sql_profiler']; | |||
| $dbConfig['profiler'] = @$config->Debug['enable_sql_profiler']; | |||
There was a problem hiding this comment.
when config fails to be created there is no information in the config structure, but this code path is still executed (because of FrontController::__destruct). Code needs to default value to false in this case.
|
Nice, less technical debt and code that makes more sense now 👍 |
diosmosis
pushed a commit
that referenced
this pull request
Oct 28, 2014
Use exceptions instead of calls to Piwik_ExitWithMessage. Also includes refactoring Piwik_ExitWithMessage so no echo-ing or exit-ing is done by the function (function is renamed), modification to Log.php so it will work even if config is empty, and, includes event that allows modification of error page contents.
|
Awesome!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Also includes refactoring Piwik_ExitWithMessage so no echo-ing or exit-ing is done by the function (function is renamed). Includes modification to Log.php so it will work even if config is empty. Finally, includes event that allows modification of error page contents.
Thoughts and reviews are welcome (cc @mattab @mnapoli @tsteur ).
Tests I did: