New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show development commands only if development mode is enabled #6533
Comments
👍 and FYI there are users deploying Piwik in production from Git (faq) |
See #6536 re development config enabled by default |
One problem that I see here... For example What development mode basically does is:
Usually one would have more Unit and Integration tests (both with caching disabled by default) and less System Tests (with caching enabled) and speed etc would be less of a problem. So actual question is shall we enable or disable development mode in tests? Maybe it is worth doing one test run to see how much slower the tests will be. If we choose to keep development mode in tests disabled we should not hide As mentioned above I would probably enable development mode in Unit and Integration tests but not for System tests. Alternatively maybe we need a separate config flag for caching or so? I wrote much more than I wanted, sorry! :) |
yes it would be useful to know how much slower it makes the tests.
👍 |
@sgiehl I have prepared a patch to disable all translation commands if development mode is disabled. Haven't committed it yet as I am not sure if they are used in some other scripts? Where maybe development mode is not enabled yet? Can I commit it? |
I do not see any problems with having the translation commands available only in developer mode. |
…he command will be only available via git in the future as we hopefully remove TestRunner plugin from latest.zip
FYI: I did a test run on AWS and did not see a difference in execution time for system tests when development mode is enabled which is a bit surprising. Maybe it does not use the actual config when running the tests? On the other side we do not really have to enable development mode in tests. Not sure what to do. Maybe we simply leave it like it is ^^ |
Closing it for now as done for most commands. Only test related commands are still visible which could be removed by removing the TestRunner plugin in latest.zip |
For example we should hide several generate commands, tests commands, sync screenshots, ... etc if development mode is disabled. It is as easy as adding the following method.
This makes it much easier for regular users. Maybe we can also enable development mode in GIT by default but disable it in build. So developers will always directly see all commands.
The text was updated successfully, but these errors were encountered: