Add example archiver and CoreConsole task to generate Archiver into plugin. #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $this->setName('generate:archiver') | ||
| ->setDescription('Adds an Archiver to an existing plugin') | ||
| ->addOption('pluginname', null, InputOption::VALUE_REQUIRED, 'The name of an existing plugin which does not have an API yet'); |
There was a problem hiding this comment.
Text should be "... does not have an Archiver yet"
|
Off topic: Maybe it makes sense to think about a refactoring of the Archiver in the next 3-4 months. Usually, I build a generator after making the API's simpler to avoid people generating things that will be deprecated later. Providing a very simple API for Archiver would be awesome but also really hard. |
|
@tsteur - I've included your feedback suggestions. Would you mind taking a look again and letting me know what you think ? Cheers! |
| { | ||
| /** | ||
| * It is a good practice to store your archive names (reports stored in database) | ||
| * in Archiver class constants. You can define as many record namesas you want |
|
Looks good otherwise, just the two changes and then we can merge. |
|
@tsteur thanks for feedback. Commited changes to repo. |
tsteur
added a commit
that referenced
this pull request
Nov 12, 2014
Add example archiver and CoreConsole task to generate Archiver into plugin.
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6516