Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry pages footer links lead to "Action not found" #6514

Merged
merged 1 commit into from Oct 27, 2014

Conversation

czolnowski
Copy link
Contributor

To reproduce this bug:

  1. Goto Action > Entry pages
  2. Click on at Entry page titles the bottom of the page (related reports)
  3. Click on Entry pages again at the bottom of the report (NOT in the menu!)

Attaching screen from demo.piwik.org:
demo-piwik-org-bug

My changes fix these error. I'm not sure what's the purpose of these lines. Maybe @tsteur will know that. Looks like you're author of this lines.

@tsteur
Copy link
Member

tsteur commented Oct 23, 2014

It says basically if inside a widget only load the report with not inside a widget load the report plus the headline. It might break some other issues such as exporting reports or reloading reports in dashboard etc. Not sure why this is in GetEntryPageUrls... Similar code is somewhere more "central" so might be not needed, maybe it is... :)

@czolnowski
Copy link
Contributor Author

@tsteur: Thanks for your comment. My PR passed tests what's mean that every screenshot was correct, right? I couldn't find in Piwik GetEntryPageUrls routing, so I think that some dead code.

@mattab: What you think? It was reported by one of PiwikPRO client and I've patched its Piwik instance (2.6.1) with this PR. I don't see any complains.

@tsteur
Copy link
Member

tsteur commented Oct 27, 2014

@czolnowski FYI: the action is a "virtual" action and routing is done here https://github.com/piwik/piwik/blob/master/core/FrontController.php#L165 . A "virtual" action can be overwritten in the controller itself and if not the default implementation in CoreHome is used.

The code you removed looks like it should be removed indeed

@mattab mattab changed the title Entry pages bug Entry pages footer links lead to "Action not found" Oct 27, 2014
mattab pushed a commit that referenced this pull request Oct 27, 2014
Entry pages footer links lead to "Action not found"
@mattab mattab merged commit 311d8f8 into matomo-org:master Oct 27, 2014
@mattab
Copy link
Member

mattab commented Oct 27, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants