@czolnowski opened this Pull Request on October 23rd 2014 Contributor

To reproduce this bug:

  1. Goto Action > Entry pages
  2. Click on at Entry page titles the bottom of the page (related reports)
  3. Click on Entry pages again at the bottom of the report (NOT in the menu!)

Attaching screen from demo.piwik.org:

My changes fix these error. I'm not sure what's the purpose of these lines. Maybe @tsteur will know that. Looks like you're author of this lines.

@tsteur commented on October 23rd 2014 Owner

It says basically if inside a widget only load the report with not inside a widget load the report plus the headline. It might break some other issues such as exporting reports or reloading reports in dashboard etc. Not sure why this is in GetEntryPageUrls... Similar code is somewhere more "central" so might be not needed, maybe it is... :)

@czolnowski commented on October 24th 2014 Contributor

@tsteur: Thanks for your comment. My PR passed tests what's mean that every screenshot was correct, right? I couldn't find in Piwik GetEntryPageUrls routing, so I think that some dead code.

@mattab: What you think? It was reported by one of PiwikPRO client and I've patched its Piwik instance (2.6.1) with this PR. I don't see any complains.

@tsteur commented on October 27th 2014 Owner

@czolnowski FYI: the action is a "virtual" action and routing is done here https://github.com/piwik/piwik/blob/master/core/FrontController.php#L165 . A "virtual" action can be overwritten in the controller itself and if not the default implementation in CoreHome is used.

The code you removed looks like it should be removed indeed

@mattab commented on October 27th 2014 Owner


This Pull Request was closed on October 27th 2014
Powered by GitHub Issue Mirror