Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release WebsiteGroups plugin in the Marketplace #6502

Closed
mattab opened this issue Oct 23, 2014 · 6 comments
Closed

Release WebsiteGroups plugin in the Marketplace #6502

mattab opened this issue Oct 23, 2014 · 6 comments
Assignees
@tsteur
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.9.0

Comments

@mattab
Copy link
Member

mattab commented Oct 23, 2014

The goal of this issue is to release our WebsiteGroups plugin in the marketplace.

This plugin will let you:

  • Allow users to assign websites to groups in the UI
  • Websites dashboard to show websites grouped by Group, and for each group show the sum of visits/actions/revenue for websites within this group
  • In the 'All Websites' dashboard, the Super User could see an aggregate number of visits/pages for the group. Websites would appear below their group row.
  • The user can set the groups within the All Websites dashboard, create a group, Move a website into a group, Move a website out of a group, Move a website into a group not visible on the current page, Allow to rename a group, Allow to search within websites and groups with the All websites search field,
  • Website selector show the website groups eg. prefix with the group name: [$groupName] $siteName, website selector search would also search for groups

Follows up #2174
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 23, 2014
@mattab mattab added this to the Piwik 2.9.0 milestone Oct 23, 2014
@mattab mattab mentioned this issue Oct 23, 2014
Closed
@mattab mattab modified the milestones: Piwik 2.10.0 , Piwik 2.9.0 Oct 23, 2014
@tsteur
Copy link
Member

tsteur commented Nov 7, 2014

I'll change license to GPL v3+ and the Author to "Piwik PRO" as done in the other plugins that are published on the Marketplace. And I'll make the repository public. Are there any objections?

@mattab
Copy link
Member Author

mattab commented Nov 7, 2014

sounds good, all our free plugins will be under GPL v3+ license!

@tsteur
Copy link
Member

tsteur commented Nov 7, 2014

Prepared and repository is public. We should only have to tag a new version. There is one remaining "problem": What is the correct header to be used in the files? See https://github.com/PiwikPRO/plugin-WebsiteGroups/blob/master/angularjs/admin/admin-controller.js#L1

Another plugin that is also published on the Marketplace uses the same header https://github.com/PiwikPRO/plugin-AdvancedCampaignReporting/blob/master/Archiver.php#L1 but it doesn't match the license. Another Piwik PRO plugin that is published on the Marketplace uses the Piwik headers (not Piwik PRO) https://github.com/PiwikPRO/plugin-InterSites/blob/master/Model/DistinctMetricsAggregator.php#L2

I guess we should use

<?php
/**
 * Copyright (C) Piwik PRO 
 *
 * @link http://piwik.pro
 * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
 */

@tsteur
Copy link
Member

tsteur commented Nov 7, 2014

Forget it. I found the email...

/**
 * Piwik PRO - cloud hosting and enterprise analytics consultancy
 * from the creators of Piwik.org
 *
 * @link http://piwik.pro
 * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
 *
 */

@mattab
Copy link
Member Author

mattab commented Nov 7, 2014

@tsteur see also this issue https://github.com/PiwikPRO/plugin-AdvancedCampaignReporting/issues/5

@tsteur
Copy link
Member

tsteur commented Nov 7, 2014

Plugin available at http://plugins.piwik.org/WebsiteGroups

Did a test installation and update via the Piwik UI and both worked.

@tsteur tsteur closed this as completed Nov 7, 2014
@tsteur tsteur self-assigned this Nov 7, 2014
@tsteur tsteur modified the milestones: Piwik 2.9.0, Piwik 2.10.0 Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@tsteur @mattab