Suppress cron errors while performing file cleanup #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report! instead of suppressing the warning could you maybe wrap in |
mattab
added
the
Pull Request WIP
|
Yes, but that would still leave a small, albeit smaller than before, race window between when file_exists is called and filemtime is called. I do still think that the !== FALSE check needs to be there regardless just in case there are any other problems with the filemtime call, since that failure ends up allowing unlink() to be called, because FALSE is less than one week ago... |
+1 |
mattab
pushed a commit
that referenced
this pull request
Oct 21, 2014
Suppress cron errors while performing file cleanup
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing simultaneous cron core:archive runs for large instances, there is a race condition during the file cleanup phase when one process sees the files of another process just before the other process deletes those files, causing the filemtime() call to fail since the file no longer exists. Also, since the return value from filemtime() is not checked for failure (=== FALSE), it tries to unlink() the file on failure, which also fails. At the least, this is causing unnecessary emailings from the cron process. The failure of filemtime() is harmless, though unlinking on that failure may not be. The filemtime() failure can be safely ignored since this function's only purpose is to clean up old files, and the failure just means the file no longer exists.