Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Pivot: reads only "from" from date range and fails. #6479

Closed
nkuehn opened this issue Oct 20, 2014 · 2 comments
Closed

Events Pivot: reads only "from" from date range and fails. #6479

nkuehn opened this issue Oct 20, 2014 · 2 comments
Assignees
@diosmosis

Comments

@nkuehn
Copy link

nkuehn commented Oct 20, 2014

  • go to Actions->Events
  • select a date range in the date selector (showing e.g. "Date range: From 2014-10-01 to 2014-10-10")

    works

  • switch to pivot view in the widget settings

    error: WARN CoreHome[2014-10-20 15:45:54] [5e6f8] Failed to get data from API: The date '2014-10-01' is not a correct date range. It should have the following format: 'lastN', 'previousN', 'YYYY-MM-DD,YYYY-MM-DD'.

  • select a single day or a week

    pivot works.

Stack trace:

#0 /srv/www/piwik.excentos.com/piwik/core/Period.php(102): Piwik\Period\Range->generate()
#1 /srv/www/piwik.excentos.com/piwik/core/Period/Range.php(96): Piwik\Period->getDateStart()
#2 /srv/www/piwik.excentos.com/piwik/core/Period.php(272): Piwik\Period\Range->getDateStart()
#3 /srv/www/piwik.excentos.com/piwik/core/Archive/DataCollection.php(120): Piwik\Period->getRangeString()
#4 /srv/www/piwik.excentos.com/piwik/core/Archive.php(506): Piwik\Archive\DataCollection->__construct(Array, 'blob', Array, Array, NULL)
#5 /srv/www/piwik.excentos.com/piwik/core/Archive.php(375): Piwik\Archive->get('Events_name_cat...', 'blob', '2')
#6 /srv/www/piwik.excentos.com/piwik/core/Archive.php(470): Piwik\Archive->getDataTable('Events_name_cat...', '2')
#7 /srv/www/piwik.excentos.com/piwik/plugins/Events/API.php(156): Piwik\Archive::getDataTableFromArchive('Events_name_cat...', '1', 'range', '2014-10-09', false, false, '2')
#8 /srv/www/piwik.excentos.com/piwik/plugins/Events/API.php(203): Piwik\Plugins\Events\API->getDataTable('getCategoryFrom...', '1', 'range', '2014-10-09', false, false, '2')
#9 [internal function]: Piwik\Plugins\Events\API->getCategoryFromNameId('1', 'range', '2014-10-09', '2', false)
#10 /srv/www/piwik.excentos.com/piwik/core/API/Proxy.php(209): call_user_func_array(Array, Array)
#11 /srv/www/piwik.excentos.com/piwik/core/API/Request.php(216): Piwik\API\Proxy->call('\Piwik\Plugins\...', 'getCategoryFrom...', Array)
#12 /srv/www/piwik.excentos.com/piwik/core/API/Request.php(304): Piwik\API\Request->process()
#13 /srv/www/piwik.excentos.com/piwik/core/Plugin/Report.php(646): Piwik\API\Request::processRequest('Events.getCateg...', Array)
#14 /srv/www/piwik.excentos.com/piwik/core/DataTable/Filter/PivotByDimension.php(290): Piwik\Plugin\Report->fetchSubtable(2, Array)
#15 /srv/www/piwik.excentos.com/piwik/core/DataTable/Filter/PivotByDimension.php(263): Piwik\DataTable\Filter\PivotByDimension->loadSubtable(Object(Piwik\DataTable), Object(Piwik\DataTable\Row))
#16 /srv/www/piwik.excentos.com/piwik/core/DataTable/Filter/PivotByDimension.php(192): Piwik\DataTable\Filter\PivotByDimension->getIntersectedTable(Object(Piwik\DataTable), Object(Piwik\DataTable\Row))
#17 /srv/www/piwik.excentos.com/piwik/core/DataTable.php(425): Piwik\DataTable\Filter\PivotByDimension->filter(Object(Piwik\DataTable))
#18 /srv/www/piwik.excentos.com/piwik/core/API/ResponseBuilder.php(172): Piwik\DataTable->filter('PivotByDimensio...', Array)
#19 /srv/www/piwik.excentos.com/piwik/core/API/ResponseBuilder.php(91): Piwik\API\ResponseBuilder->handleDataTable(Object(Piwik\DataTable))
#20 /srv/www/piwik.excentos.com/piwik/core/API/Request.php(218): Piwik\API\ResponseBuilder->getResponse(Object(Piwik\DataTable), 'Events', 'getAction')
#21 /srv/www/piwik.excentos.com/piwik/core/ViewDataTable/Request.php(48): Piwik\API\Request->process()
#22 /srv/www/piwik.excentos.com/piwik/core/Plugin/ViewDataTable.php(327): Piwik\ViewDataTable\Request->loadDataTableFromAPI(Array)
#23 /srv/www/piwik.excentos.com/piwik/core/Plugin/Visualization.php(166): Piwik\Plugin\ViewDataTable->loadDataTableFromAPI(Array)
#24 /srv/www/piwik.excentos.com/piwik/core/Plugin/ViewDataTable.php(414): Piwik\Plugin\Visualization->buildView()
#25 /srv/www/piwik.excentos.com/piwik/core/Plugin/Report.php(304): Piwik\Plugin\ViewDataTable->render()
#26 /srv/www/piwik.excentos.com/piwik/plugins/CoreHome/Controller.php(78): Piwik\Plugin\Report->render()
#27 [internal function]: Piwik\Plugins\CoreHome\Controller->renderReportWidget('Events', 'getAction')
#28 /srv/www/piwik.excentos.com/piwik/core/FrontController.php(579): call_user_func_array(Array, Array)
#29 /srv/www/piwik.excentos.com/piwik/core/FrontController.php(87): Piwik\FrontController->doDispatch(NULL, NULL, NULL)
#30 /srv/www/piwik.excentos.com/piwik/core/dispatch.php(34): Piwik\FrontController->dispatch()
#31 /srv/www/piwik.excentos.com/piwik/index.php(46): require_once('/srv/www/piwik....')
#32 {main}

The date '2014-10-09' is not a correct date range. It should have the following format: 'lastN', 'previousN', 'YYYY-MM-DD,YYYY-MM-DD'.

The date range is passed cleanly in the HTTP calls (date=2014-10-10,2014-10-16)

My suspect is this line: https://github.com/piwik/piwik/blob/5754abc5673707697769bf9ed815ea2af1d62561/core/DataTable/Filter/PivotByDimension.php#L431 -> "date" parameter parses just the start date no matter what kind of period.

(mentioned first in #6364 )
@diosmosis diosmosis self-assigned this Oct 20, 2014
@nkuehn
Copy link
Author

nkuehn commented Oct 21, 2014

:-) that was fast.

@diosmosis
Copy link
Member

Your intuition was correct, definitely helped :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diosmosis @nkuehn