Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Bower for JS / CSS / other assets #6469

Closed
tsteur opened this issue Oct 20, 2014 · 8 comments
Closed

Use Bower for JS / CSS / other assets #6469

tsteur opened this issue Oct 20, 2014 · 8 comments
Assignees
@tsteur
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.9.0

Comments

@tsteur
Copy link
Member

tsteur commented Oct 20, 2014

See http://bower.io/

A package manager for the web.

Web sites are made of lots of things — frameworks, libraries, assets, utilities, and rainbows. Bower manages all these things for you.
tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 some initial work for using bower
20c7801
tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 fix test as it should ignore bower_components folder
9b6e151
tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 forgot to commit this file
9946f0e
@tsteur
Copy link
Member Author

tsteur commented Oct 20, 2014

FYI: In the beginning we will commit the libs/bower_components directory as bower requires nodejs which maybe not everyone has installed. The Piwik team will use bower / nodejs to update the dependencies and commit them. Later we could try to use for instance https://github.com/francoispluchino/composer-asset-plugin once it supports project mode.

@diosmosis
Copy link
Member

Can we use http://bowerphp.org/ ?

@tsteur
Copy link
Member Author

tsteur commented Oct 20, 2014

Nope, doesn't work

tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 update smartbanner lib and make sure it works
7b00eb1
@diosmosis
Copy link
Member

Could you elaborate? Ie, is it too alpha? Does it use a separate package repo?

tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 fix screenshot diff does not work, updated changelog, use …
94d2d10 
…jquery-ui.css from bower
@tsteur
Copy link
Member Author

tsteur commented Oct 20, 2014

I tried it in the beginning when adding the bower.json but it couldn't resolve all versions and just errored

@diosmosis
Copy link
Member

well that sucks :(

tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 looks like we cannot use the jquery-ui.css provided in the…
e2c137c 
… bower component as we are using a custom theme? this would explain why we were using jquery-ui 1.10.4 and but the css from 1.10.1. Not sure if it is a good idea to use 1.10.1 CSS with version 1.11.2. We will see...
@tsteur
Copy link
Member Author

tsteur commented Oct 20, 2014

FYI: In case someone is using Webstorm / PHPStorm:

With integrated Bower package manager, you’ll be able to search for, install and manage client-side libraries and frameworks for your project with ease, right in the IDE.

(There is also a plugin for Atom and Sublime)

tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 ignore more directories
4751444
tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 with jquery-ui 1.11.1 the UI test run about 80% slower and…
a2fb939 
… runs out of time very soon. So going back to 1.10.4
@tsteur tsteur mentioned this issue Oct 20, 2014
Merged
tsteur added a commit that referenced this issue Oct 20, 2014
@tsteur
refs #6469 move css file back where it was placed before maybe this m…
5f4e034 
…akes ui tests fast again
@tsteur
Copy link
Member Author

tsteur commented Oct 21, 2014

Done for the libraries that we use and are on bower. We are using only official repositories.

Don't think there is a lot to explain. As with composer one only has to run bower update to update dependencies and that's it.

@tsteur tsteur closed this as completed Oct 21, 2014
@tsteur tsteur self-assigned this Oct 21, 2014
@tsteur tsteur added this to the Piwik 2.9.0 milestone Oct 21, 2014
@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 21, 2014
@Findus23 Findus23 mentioned this issue Sep 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@diosmosis @tsteur