Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data table settings icon does not work in IE9 #6462

Closed
MichalTomczak opened this issue Oct 17, 2014 · 5 comments
Closed

data table settings icon does not work in IE9 #6462

MichalTomczak opened this issue Oct 17, 2014 · 5 comments
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone
2.9.0

Comments

@MichalTomczak
Copy link

You can hover over the icon but if you click it, it does not work
screenshot 2014-10-17 11 03 10 1
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority. labels Oct 17, 2014
@mattab mattab modified the milestones: Piwik 2.9.0, Piwik 2.8.1 Oct 17, 2014
@diosmosis diosmosis self-assigned this Oct 19, 2014
@diosmosis
Copy link
Member

I can't reproduce this using modern.ie on IE9. When I hover the options display and when I click an option (eg, 'make it flat') it is applied. Clicking on the gear does nothing, but I don't think it's supposed to.

@mattab
Copy link
Member

mattab commented Oct 20, 2014

Thanks @diosmosis for checking on IE9

Clicking is not supposed to do anything here @MichalTomczak so it works as expected

@mattab mattab closed this as completed Oct 20, 2014
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Oct 20, 2014
@p-banaszczyk
Copy link

@mattab in ie9 you won't be able to click on the popup, as it will be closed, as soon as you will move your mouse to point the link. I confirmed it, and it's not working on ie9

@sgiehl
Copy link
Member

sgiehl commented Oct 20, 2014

Thats correct. Had a quick look at that right now.
Guess that might be a CSS issue.

@sgiehl sgiehl reopened this Oct 20, 2014
@sgiehl sgiehl removed the worksforme The issue cannot be reproduced and things work as intended. label Oct 20, 2014
@sgiehl
Copy link
Member

sgiehl commented Oct 20, 2014

In IE9 the li's are getting a style="width: 0" which breaks the layout.
It is caused by an IE7 fix which is also applied in IE9:
https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/dataTable.js#L1312
Maybe it would just be enough to check if 'html' has the class 'old-ie', which will only be the case for IE < 9.
Btw. has anyone tested that on IE8 or IE7 ?

@mattab mattab modified the milestones: Piwik 2.8.1, Piwik 2.9.0 Oct 21, 2014
@sgiehl sgiehl assigned sgiehl and unassigned diosmosis Oct 21, 2014
@sgiehl sgiehl closed this as completed in 9fef02e Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
5 participants
@diosmosis @mattab @sgiehl @p-banaszczyk @MichalTomczak