Check if a file was actually copied when copying a file #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and whether they have same content. Wondering about problems re using different filesystems for tmp and other directories and whether opcache causes any problems but should not
…fore triggering the error
mattab
pushed a commit
that referenced
this pull request
Oct 20, 2014
Check if a file was actually copied when copying a file
mattab
pushed a commit
that referenced
this pull request
Oct 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6444
It will compare source file with destination and trigger an exception if the content does not match. It uses md5_file which basically gets the content of the file and builds a md5 hash on it. We could compare directly but thought using this might use less memory etc (have not tested it and memory might not even be a problem but they all do the same in the end)
@mattab feel free to merge. Not sure if it will prevent such issues in the future or whether there are any side effects but should work. Maybe you can release a new beta and we can see? Only checking PHP files as they are most critical and for faster performance / less memory.