Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force browser cache reload after activating/deactivating plugin #6437

Closed
diosmosis opened this issue Oct 13, 2014 · 5 comments
Closed

force browser cache reload after activating/deactivating plugin #6437

diosmosis opened this issue Oct 13, 2014 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@diosmosis
Copy link
Member

If a plugin is activated, the JS & CSS will be re-aggregated and merged, but the browser won't try to issue a request for the new merged assets since it will still have a cached version. Somehow the browser cache needs to be reset after a plugin is activated.

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 13, 2014
@gaumondp
Copy link

IMHO , also related to #6402.

@mattab
Copy link
Member

mattab commented Oct 17, 2014

If a plugin is activated, the JS & CSS will be re-aggregated and merged, but the browser won't try to issue a request for the new merged assets since it will still have a cached version. Somehow the browser cache needs to be reset after a plugin is activated.

Are you sure that this works this way? IIRC when disabling plugin it should invalidate the getNonCoreJs cache in the browser by regenerating a new cb cache buster value?

@diosmosis
Copy link
Member Author

Looks like there's a new cache buster, however, on chrome it doesn't result in the new script being loaded until I reload the page. I haven't looked into the issue that much, though.

@mattab
Copy link
Member

mattab commented Nov 3, 2014

Looks like there's a new cache buster, however, on chrome it doesn't result in the new script being loaded until I reload the page.

Ok so maybe this is rather a browser bug? Hopefully it will be fixed sometimes!

@mattab mattab added this to the Short term milestone Nov 3, 2014
@diosmosis
Copy link
Member Author

Looks like a browser bug, no issue w/ firefox.

@mattab mattab closed this as completed Dec 1, 2014
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants