Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP: use Geocoder? #6433

Open
ThaDafinser opened this issue Oct 13, 2014 · 5 comments
Open

GeoIP: use Geocoder? #6433

ThaDafinser opened this issue Oct 13, 2014 · 5 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@ThaDafinser
Copy link
Contributor

i just found http://geocoder-php.org/Geocoder/ https://github.com/geocoder-php/Geocoder

It comes with many GeoIP adapters, which could directly be used by Piwik instead of the custom implementation: https://github.com/piwik/piwik/blob/master/plugins/UserCountry/LocationProvider/GeoIp.php

If a replacement would happen, this would be a good point that the administration GUI is also changed, to list all available GeoIP sources and order them by priority. (see using Using The ChainProvider)

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 3, 2014
@mattab mattab added this to the Long term milestone Nov 3, 2014
@ThaDafinser
Copy link
Contributor Author

I created a prototype to replace the current UserCountry or as a seperate plugin...needs to be decided later...

New features:

  • unlimited providers (with a chain provider)
  • define provider priority
  • BrowserLocale is now also a provider and not an extra option
  • based on GeoCoder which haves a lot of other providers

see https://github.com/ThaDafinser/Piwik-GeoIpChain

Please provide some feedback here, or at the repo...thx 😄

//cc @mattab

@sgiehl
Copy link
Member

sgiehl commented Oct 19, 2015

+1 for the idea to improve geolocation. I like the idea of using kind of detection chain to improve results.

@ThaDafinser
Copy link
Contributor Author

@sgiehl it's also required if you want to easily track and geolocate intranet and internet traffic at the same time.

Currently u could use the builtin plugin + https://github.com/ThaDafinser/Piwik-IntranetGeoIP but it's not so easy for enduser

@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@grzchr15
Copy link

Reminder: Please help to be able to chain LocationProviders
1.) Intranet ( internal IPAM database)
2.) if ip not found use GeoIP2
This is a maybe smaller solution as a fullblown geocoer solution.

Just a hook is needed in GeoIP2 to be able to use https://github.com/ThaDafinser/Piwik-IntranetGeoIP without patching the GeoIP2

see
https://github.com/grzchr15/piwik/blob/master/plugins/GeoIp2/LocationProvider/GeoIp2/Php.php

@grzchr15
Copy link

grzchr15 commented Jan 4, 2021

Any chance to get a chainable plugin feature to chain
-IP- to intranet location and if not found ( patched example see https://gist.github.com/grzchr15/dfc8e975482ad99e94b620b033da1da5 )
-use GeoIp2 with support from Maxmind/DBIp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants