Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6215 Added a "learn more" link on "Others" row in reports #6401

Merged
merged 1 commit into from Oct 8, 2014

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Oct 8, 2014

This is a fix for #6215

When not hovering the row (no change):

normal

When hovering the row (new link):

hover

(don't mind the translation)

To achieve this I added a new method handleSummaryRow() in dataTable.js I hope it makes sense. If not, let me know.

@mnapoli mnapoli added this to the Piwik 2.8.0 milestone Oct 8, 2014
@mattab
Copy link
Member

mattab commented Oct 8, 2014

Loooks good 👍

mattab pushed a commit that referenced this pull request Oct 8, 2014
Fix for #6215 Added a "learn more" link on "Others" row in reports
@mattab mattab merged commit 55e9cb2 into master Oct 8, 2014
@mnapoli mnapoli deleted the bugfix/6215 branch October 8, 2014 05:35
mnapoli added a commit that referenced this pull request Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants