Refactoring in ScheduledReports to remove useless indentation #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
force-pushed
the
code-refactorings
branch
from
7404453
to
e263aba
Compare
I have refactored the code a bit to make it (hopefully) more readable. I have replaced this:
```php
if (self::manageEvent($reportType)) {
// do something
}
```
By this:
```php
if (! self::manageEvent($reportType)) {
return;
}
// do something
```
It's not much but it removes one level of indentation in almost the whole class, which is kind of nice.
FYI, this is one of the "object calisthenics" rules.
mnapoli
force-pushed
the
code-refactorings
branch
from
e263aba
to
49a3a64
Compare
mattab
pushed a commit
that referenced
this pull request
Oct 8, 2014
Refactoring in ScheduledReports to remove useless indentation
|
Nice change improving readability! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the code a bit to make it (hopefully) more readable.
The diff is going crazy, but basically I have just replaced this:
By this:
It's not much but it removes one level of indentation in almost the whole class (almost all the methods were like that), which is kind of nice.
(by the way this is one of the "object calisthenics" rules)