Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4616: Show only the first characters of tokens in the admin #6394

Merged
merged 1 commit into from Oct 7, 2014

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Oct 7, 2014

Tokens are shown in full only when we click on it.

Once token are expanded, clicking again will not collapse them again because that prevents from selecting them and copying them in the clipboard.

Tokens are shown in full only when we click on it.
@mnapoli mnapoli added this to the Piwik 2.8.0 milestone Oct 7, 2014
mattab pushed a commit that referenced this pull request Oct 7, 2014
Fixes #4616: Show only the first characters of tokens in the admin
@mattab mattab merged commit 87df2a9 into master Oct 7, 2014
@mattab
Copy link
Member

mattab commented Oct 7, 2014

Nice, thanks for the nice security-aware PR!

@mnapoli mnapoli deleted the feature/collapse-token branch October 7, 2014 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants