Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when trusted_hosts is set to an invalid host, silently ignore the malformed trusted_host #6389

Closed
andre-dierker opened this issue Oct 6, 2014 · 4 comments
Closed

when trusted_hosts is set to an invalid host, silently ignore the malformed trusted_host #6389

andre-dierker opened this issue Oct 6, 2014 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
Backlog (Help wan...

Comments

@andre-dierker
Copy link

After adding a second trusting URL, Piwik seems a bit broken :)

www metapixl com-piwik-index php module corehome action _009

Warning: preg_match(): Unknown modifier 'p' in /var/www/piwik/core/Url.php on line 255 

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [:]
#1 preg_match(...) called at [/var/www/piwik/core/Url.php:255]
#2 Piwik\Url::isValidHost(...) called at [/var/www/piwik/core/Url.php:311]
#3 Piwik\Url::getHost(...) called at [/var/www/piwik/core/Url.php:357]
#4 Piwik\Url::getCurrentHost(...) called at [/var/www/piwik/core/Url.php:105]
#5 Piwik\Url::getCurrentUrlWithoutFileName(...) called at [/var/www/piwik/core/SettingsPiwik.php:170]
#6 Piwik\SettingsPiwik::getPiwikUrl(...) called at [/var/www/piwik/core/FrontController.php:394]
#7 Piwik\FrontController->init(...) called at [/var/www/piwik/core/dispatch.php:33]
#8 require_once(...) called at [/var/www/piwik/index.php:46]


Warning: preg_match(): Unknown modifier 'p' in /var/www/piwik/core/Url.php on line 255 

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [:]
#1 preg_match(...) called at [/var/www/piwik/core/Url.php:255]
#2 Piwik\Url::isValidHost(...) called at [/var/www/piwik/core/Url.php:311]
#3 Piwik\Url::getHost(...) called at [/var/www/piwik/core/Url.php:357]
#4 Piwik\Url::getCurrentHost(...) called at [/var/www/piwik/core/Url.php:105]
#5 Piwik\Url::getCurrentUrlWithoutFileName(...) called at [/var/www/piwik/core/SettingsPiwik.php:170]
#6 Piwik\SettingsPiwik::getPiwikUrl(...) called at [/var/www/piwik/core/View.php:144]
#7 Piwik\View->__construct(...) called at [/var/www/piwik/plugins/CoreHome/Controller.php:133]
#8 Piwik\Plugins\CoreHome\Controller->getDefaultIndexView(...) called at [/var/www/piwik/plugins/CoreHome/Controller.php:168]
#9 Piwik\Plugins\CoreHome\Controller->index(...) called at [:]
#10 call_user_func_array(...) called at [/var/www/piwik/core/FrontController.php:577]
#11 Piwik\FrontController->doDispatch(...) called at [/var/www/piwik/core/FrontController.php:86]
#12 Piwik\FrontController->dispatch(...) called at [/var/www/piwik/core/dispatch.php:34]
#13 require_once(...) called at [/var/www/piwik/index.php:46]


Warning: preg_match(): Unknown modifier 'p' in /var/www/piwik/core/Url.php on line 255 

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [:]
#1 preg_match(...) called at [/var/www/piwik/core/Url.php:255]
#2 Piwik\Url::isValidHost(...) called at [/var/www/piwik/core/Url.php:311]
#3 Piwik\Url::getHost(...) called at [/var/www/piwik/core/Url.php:357]
#4 Piwik\Url::getCurrentHost(...) called at [/var/www/piwik/core/Url.php:105]
#5 Piwik\Url::getCurrentUrlWithoutFileName(...) called at [/var/www/piwik/core/SettingsPiwik.php:170]
#6 Piwik\SettingsPiwik::getPiwikUrl(...) called at [/var/www/piwik/plugins/CoreAdminHome/CustomLogo.php:130]
#7 Piwik\Plugins\CoreAdminHome\CustomLogo->getPathToLogo(...) called at [/var/www/piwik/plugins/CoreAdminHome/CustomLogo.php:43]
#8 Piwik\Plugins\CoreAdminHome\CustomLogo->getSVGLogoUrl(...) called at [/var/www/piwik/plugins/API/API.php:303]
#9 Piwik\Plugins\API\API->getSVGLogoUrl(...) called at [/var/www/piwik/core/Plugin/Controller.php:683]
#10 Piwik\Plugin\Controller->setBasicVariablesView(...) called at [/var/www/piwik/core/Plugin/Controller.php:626]
#11 Piwik\Plugin\Controller->setGeneralVariablesView(...) called at [/var/www/piwik/plugins/CoreHome/Controller.php:134]
#12 Piwik\Plugins\CoreHome\Controller->getDefaultIndexView(...) called at [/var/www/piwik/plugins/CoreHome/Controller.php:168]
#13 Piwik\Plugins\CoreHome\Controller->index(...) called at [:]
#14 call_user_func_array(...) called at [/var/www/piwik/core/FrontController.php:577]
#15 Piwik\FrontController->doDispatch(...) called at [/var/www/piwik/core/FrontController.php:86]
#16 Piwik\FrontController->dispatch(...) called at [/var/www/piwik/core/dispatch.php:34]
#17 require_once(...) called at [/var/www/piwik/index.php:46]


Warning: preg_match(): Unknown modifier 'p' in /var/www/piwik/core/Url.php on line 255 

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [:]
#1 preg_match(...) called at [/var/www/piwik/core/Url.php:255]
#2 Piwik\Url::isValidHost(...) called at [/var/www/piwik/core/Url.php:311]
#3 Piwik\Url::getHost(...) called at [/var/www/piwik/core/Url.php:357]
#4 Piwik\Url::getCurrentHost(...) called at [/var/www/piwik/core/Url.php:73]
#5 Piwik\Url::getCurrentUrl(...) called at [/var/www/piwik/core/View.php:225]
#6 Piwik\View->render(...) called at [/var/www/piwik/plugins/CoreHome/Controller.php:169]
#7 Piwik\Plugins\CoreHome\Controller->index(...) called at [:]
#8 call_user_func_array(...) called at [/var/www/piwik/core/FrontController.php:577]
#9 Piwik\FrontController->doDispatch(...) called at [/var/www/piwik/core/FrontController.php:86]
#10 Piwik\FrontController->dispatch(...) called at [/var/www/piwik/core/dispatch.php:34]
#11 require_once(...) called at [/var/www/piwik/index.php:46]
@mattab
Copy link
Member

mattab commented Oct 6, 2014

Thanks for the report, could you paste here the text you put in the trusted_hosts config ?

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 6, 2014
@mattab mattab added this to the Short term milestone Oct 6, 2014
@andre-dierker
Copy link
Author

Hi,
I've added the second host via the web interface.
Text was: "www.metapixl.com/piwik"

config.ini.php
[...]
[General]
trusted_hosts[] = "piwik.metapixl.com"
trusted_hosts[] = "www.metapixl.com/piwik"
salt = "saltsaltsalt"

[Plugins]
[...]

@andre-dierker
Copy link
Author

OK, solved this.
trusted_host accepts only the FQDN and not an absolute Path.
Anyway, it should still be checked or has it been tested and this was the strange error message?

@mattab mattab changed the title Broken Piwik after adding trusted URL in 2.7.0 when trusted_hosts is set to an invalid host, silently ignore the malformed trusted_host Oct 9, 2014
@mattab
Copy link
Member

mattab commented Dec 1, 2014

we fixed this in some other issue, it works without error now!

@mattab mattab closed this as completed Dec 1, 2014
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @andre-dierker