Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests from plugin when packaging on the Marketplace #6386

Closed
tsteur opened this issue Oct 6, 2014 · 1 comment
Closed

Remove tests from plugin when packaging on the Marketplace #6386

tsteur opened this issue Oct 6, 2014 · 1 comment
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Oct 6, 2014

When a developer tags a plugin we will prepare the plugin for download on the Marketplace. Before packaging / building the ZIP we should remove all tests from the "tests" and "Test" folder. Otherwise the included PHP files could be executed. This should not be a security problem as it would only trigger a fatal error as it would not find any other classes and there is usually nothing to execute but could potentially be one if someone is executing plain PHP code in one of his test files. This packaging behavior would be also consistent with the one in Piwik itself.

@tsteur tsteur added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Oct 6, 2014
@mattab mattab added this to the Mid term milestone Nov 3, 2014
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Nov 3, 2014
@mattab mattab added c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. and removed c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. labels Feb 27, 2015
@tsteur tsteur closed this as completed Aug 16, 2016
@tsteur
Copy link
Member Author

tsteur commented Aug 16, 2016

was implemented recently

@mattab mattab modified the milestones: 2.16.3, Long term Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants