improve readability of code #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity of code, few refactorings, all as part of our code cleanup strategy
Conflicts: core/Tracker/Db/Mysqli.php
| return Db::fetchAll(self::getSqlAccessSite("access, t2.idsite"), $login); | ||
| $sql = self::getSqlAccessSite("access, t2.idsite"); | ||
|
|
||
| return Db::fetchAll($sql, $login); |
There was a problem hiding this comment.
Really needed? This is only one braces pair embedded.
There was a problem hiding this comment.
I don't see a huge advantage of having everything in one line. This way it is better readable and debuggable for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coding style fixes
some PHPStorm code inspection fixes
few method extractions
removed unused methods
whitespace fixes
all as part of our code cleanup strategy and to make code better readable.