Deprecate Piwik::setUserHasSuperUserAccess() and switch to using Access::doAsSuperUser() #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 30, 2014 05:37
diosmosis
force-pushed
the
set_superuser_access_refactor
branch
from
c0402a2
to
fb2d5ad
Compare
mattab
pushed a commit
that referenced
this pull request
Sep 30, 2014
Remove and deprecate Piwik::setUserHasSuperUserAccess() and switch to using Access::doAsSuperUser()
mattab
added
Task
|
Feedback
|
diosmosis
pushed a commit
that referenced
this pull request
Oct 2, 2014
…user that can execute a command can do more than a superuser already).
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
doAsSuperUser() will rescind super user access if an exception is thrown by the callback passed to it and after the callback finishes, which means super user access will not accidentally be used.
@mattab Please review & merge if the build passes.