Remove CacheFile cache from APC on write #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If APC is enabled on the piwik server, cache files written by the CacheFile class are stored in the opcode cache. This causes disk io problems when doing things like loading weblogs into piwik with the import_logs.py script, especially when running in --disable-bulk-tracking mode. In this scenario, apache write IO quickly reaches 100% and slows the import to a crawl.
|
Hmm. Seems like all of the tests that failed were related to composer install failing? |
mattab
pushed a commit
that referenced
this pull request
Sep 28, 2014
…n-write Remove CacheFile cache from APC on write
|
Sorry about that! This is an issue when new contributors like you are so kindly doing a PR but our build was already failing unfortunately... we really want to avoid this in the future see #5954 PR looks good, this is a nice edge case improvement! |
mattab
added
the
Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If APC is enabled on the piwik server, cache files written by the CacheFile
class are stored in the opcode cache. This causes disk io problems when doing
things like loading weblogs into piwik with the import_logs.py script,
especially when running in --disable-bulk-tracking mode. In this scenario,
apache write IO quickly reaches 100% and slows the import to a crawl.