Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitors having empty visits when using content tracking #6296

Closed
tsteur opened this issue Sep 25, 2014 · 5 comments
Closed

Visitors having empty visits when using content tracking #6296

tsteur opened this issue Sep 25, 2014 · 5 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 25, 2014

See http://forum.piwik.org/read.php?2,120340

I implemented content tracking on one of my websites. Now I see a lot of 'empty' visits in the visiters log. These occur next to the normal logs. Even since the visitor ID is identical the user gets logged as a new visit so the visitor count increased with 50%.

The unique visits count is still correct.

The extra log occurs on the POST action.

The content tracking is on an internal link
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 25, 2014
@tsteur tsteur added this to the Piwik 2.8.0 milestone Sep 25, 2014
@tsteur tsteur self-assigned this Sep 25, 2014
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6296 fixes Piwik detects a different visitors in case their are…
b45a415 
… multiple requests in same second
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6296 the previous code was not debugable
bd96b74
@tsteur tsteur mentioned this issue Sep 25, 2014
Closed
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6296 PHP doc
36707d4
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6296 fix plugin tests
e106e6d
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6296 I think we can now run the getLastVisitDetails test again …
960d0d1 
…as this would explain the random failure on travis
mattab added a commit that referenced this issue Sep 28, 2014
@mattab
refs #6296 maybe we can detect number of rows matched by the UPDATE q…
0b91a86 
…uery, by using Mysql client flags in both Mysqli and PDO
@mattab mattab mentioned this issue Sep 28, 2014
Merged
@mattab
Copy link
Member

mattab commented Oct 2, 2014

@tsteur Is the bug fixed now that #6323 is merged? maybe we should add a test covering this use case?

@tsteur
Copy link
Member Author

tsteur commented Oct 2, 2014

I think it should work now.

Test case is already there as you noticed you've changed expected integration files but of course you can write some more tests

@mattab
Copy link
Member

mattab commented Oct 2, 2014

The tests cases don't seem to fit the issue described here which is more about empty visits?

@tsteur
Copy link
Member Author

tsteur commented Oct 2, 2014

There were basically empty visits but you couldn't see it. now that it works some values were summed in the expected file as it is now one visit

@mattab
Copy link
Member

mattab commented Oct 2, 2014

trusting your word for it 👍

@mattab mattab closed this as completed Oct 2, 2014
This was referenced Oct 12, 2014
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
2 participants
@tsteur @mattab