Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated files to match AngularJS style guide #6292

Merged
merged 7 commits into from Sep 25, 2014
Merged

Updated files to match AngularJS style guide #6292

merged 7 commits into from Sep 25, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 24, 2014

#5983

Refactored some files,
Renamed some files
etc

@tsteur
refs #5983 started to apply the angular style guide. refactored model…
810f07c 
…s, use named functions, IIFE
@tsteur
refs #5983 always define needed dependencies so we can later find a w…
f2995e8 
…ay to minify those files
@tsteur
refs #5983 in the style guide it was suggested to use for instance th…
0332c04 
…e "." as a separator for those types which absolutely makes more sense to me. So dash can be used for naming of the component and is clearly separated from the type
@tsteur
refs #5983 more filename corrections
13b7ae4
@tsteur
refs #5983 each component should have its own file. For some reason S…
3cb6258 
…itesManager does no longer work. could not figure out why so far
@tsteur
refs #5983 updated docs for test file naming as suggested by AngularJ…
fbd208a 
…s style guide
@tsteur
refs #5983 make sites manager working again, more naming fixes
0e8b3ce
tsteur added a commit that referenced this pull request Sep 25, 2014
@tsteur
Merge pull request #6292 from piwik/5983_angularStyleGuide
8c9aab3 
Updated files to match angular style guide see #5983
@tsteur tsteur merged commit 8c9aab3 into master Sep 25, 2014
@tsteur tsteur deleted the 5983_angularStyleGuide branch September 25, 2014 05:46
@mattab
Copy link
Member

mattab commented Sep 25, 2014

Very good to see consistency in AngularJS! since these are complicated notions, it helps so much everyone who will write code to see that we all respect the same style... well done to push this early on 💯

@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: UI - UX (AngularJS twig less) labels Sep 25, 2014
@mattab mattab added this to the Piwik 2.8.0 milestone Sep 25, 2014
@mattab mattab changed the title Updated files to match angular style guide see #5983 Updated files to match AngularJS style guide see #5983 Oct 14, 2014
@mattab mattab changed the title Updated files to match AngularJS style guide see #5983 Updated files to match AngularJS style guide Oct 14, 2014
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab