Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a command to generate Angular components #6285

Closed
tsteur opened this issue Sep 24, 2014 · 2 comments
Closed

Provide a command to generate Angular components #6285

tsteur opened this issue Sep 24, 2014 · 2 comments
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 24, 2014

To guarantee we are using always best practice styles for Angular it would be good to have a generator for AngularJS components. I noticed many angular files were copied and for instance the dependencies were not adjusted. Copying other components to have a template is not bad when someone knows what the person does. Problem is for instance when the copied file does not follow guidelines / best practice etc.

We could ask a few question eg. "do you need a template/controller/..." . The generator will make sure to create the files in angularjs folder, to create a file for each component, to have correct filenames as defined in style guide, uses named functions, IIFE, ...

Maybe already in 2.8 or 2.9? As more and more components are added
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: UI - UX (AngularJS twig less) labels Sep 24, 2014
@tsteur tsteur added this to the Piwik 2.8.0 milestone Sep 24, 2014
@mattab
Copy link
Member

mattab commented Sep 24, 2014

Sounds good Thomas! it can only help team members and contributors get started faster with building a new AngularJS module. Also we have this goal of doing at least some AngularJS conversion work at every sprint going forward. this tool will come handy!

@tsteur tsteur mentioned this issue Sep 25, 2014
Closed
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6285 added a command to generate a template for an angular dire…
4ce2f50 
…ctive
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6285 better naming
95d244e
@tsteur tsteur self-assigned this Sep 25, 2014
@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2014

So far I have created only a generator to create a new directive since we are using this the most. Once you use AngularJS more often we can add more generators for filters, routes, templates, ...

@tsteur tsteur closed this as completed Sep 25, 2014
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6285 forgot to commit the actual templates
8439a88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
2 participants
@tsteur @mattab