Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AngularJS: Use controllerAs syntax #6284

Closed
tsteur opened this issue Sep 24, 2014 · 0 comments
Closed

AngularJS: Use controllerAs syntax #6284

tsteur opened this issue Sep 24, 2014 · 0 comments
Assignees
@tsteur
Milestone
2.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 24, 2014

See https://github.com/johnpapa/angularjs-styleguide#controllers

and section "Directives and ControllerAs:" in https://github.com/johnpapa/angularjs-styleguide#directives

There are many advantages, see linked docs
@tsteur tsteur added this to the Piwik 2.8.0 milestone Sep 24, 2014
@tsteur tsteur mentioned this issue Sep 25, 2014
Closed
@tsteur tsteur self-assigned this Sep 25, 2014
tsteur added a commit that referenced this issue Sep 25, 2014
@tsteur
refs #6284 converted some directive controllers to use controllerAs. …
de260c8 
…Initially I converted nearly of them but noticed it does not always make sense for directive controller so I revert most changes again. For regular controllers it still makes sense which we will use when using ngRoute
@tsteur tsteur closed this as completed Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
1 participant
@tsteur