Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DataTable\Filter & DataTableManipulators into DataTable\Transforms #6282

Closed
diosmosis opened this issue Sep 24, 2014 · 0 comments
Closed
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@diosmosis
Copy link
Member

Filters modify a DataTable, though from the name you would think they would only remove rows. Filter is therefore an inaccurate name. DataTableManipulators act the same way as Filters, though they are usually more complicated and less efficient. 'Manipulator' is, however, too generic a name.

Since the two types are very similar and neither name is descriptive enough, they should merged into one hierarchy with the base class being 'Transform'. A DataTable Transform is an algorithm that transforms the content or metadata stored in a DataTable. For efficiency, they must all be applied in-place & they should all work w/ and w/o expanded=1.

@diosmosis diosmosis added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Sep 24, 2014
@diosmosis diosmosis added this to the Short term milestone Sep 24, 2014
@mattab mattab modified the milestones: Mid term, Short term Dec 1, 2014
@mattab mattab closed this as completed Jul 8, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants