Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The import_logs.py script does not treat ".apk" files as downloads #6276

Closed
andrejb opened this issue Sep 23, 2014 · 0 comments
Closed

The import_logs.py script does not treat ".apk" files as downloads #6276

andrejb opened this issue Sep 23, 2014 · 0 comments

Comments

@andrejb
Copy link

andrejb commented Sep 23, 2014

Steps to reproduce:

  1. Use the misc/log-analytics/import_logs.py script to import a log containing a line with a GET request to a file ended with .apk.
  2. Browse Piwik to Actions -> Downloads and choose the date corresponding to the above request.

Expected result: should see the apk file download in the report.
Actual result: no apk file shown.

Example GET request log line:

127.0.0.1 - - [22/Sep/2014:07:01:06 +0000] "GET /my-app.apk HTTP/1.1" 200 1747709 "https://google.com/" "Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Firefox/24.0"

Comments:

The apk extension is not included in the DOWNLOAD_EXTENSIONS set in the misc/log-analytics/import_logs.py script. This causes imported logs to not report apk as downloads in Actions.getDownload() and Actions.getDownloads() methods.

On the other hand, the apk extension is correctly included in the js/piwik.js file.

andrejb pushed a commit to andrejb/piwik that referenced this issue Sep 23, 2014
mattab pushed a commit that referenced this issue Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant