@a4tunado opened this Pull Request on September 20th 2014
@mattab commented on September 24th 2014 Member

Thanks for the pull request! This is a good change, it just needs a little improvement to make sure in the future the feature will always work: a new test. piwik.js is tested automatically on travis CI find more info in your piwik at: /tests/javascript/

Maybe you can add a test around this code: https://github.com/piwik/piwik/blob/master/tests/javascript/index.php#L2016 - Cheers

@a4tunado commented on September 24th 2014

Hey! Just commited unit tests for thist request.

@mattab commented on September 25th 2014 Member

The tests look good! well done. And the build passes. let me know about the comment and i'll merge it!

@mattab commented on September 26th 2014 Member

looks good & well done!

This Pull Request was closed on September 26th 2014
Powered by GitHub Issue Mirror