Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make visitorId be equal by default for all Piwik.Trackers #6257

Closed
a4tunado opened this issue Sep 20, 2014 · 4 comments
Closed

Make visitorId be equal by default for all Piwik.Trackers #6257

a4tunado opened this issue Sep 20, 2014 · 4 comments
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.9.0

Comments

@a4tunado
Copy link

For now each call Piwik.Tracker().getVisitorId() returns different UUIDs if visitorUUID is not in cookies. It will be more conviniet for integration with other javascript routine if VisitorUUID will be uniq for all Piwik.Trackers by default and will be available at Piwik level.
a4tunado pushed a commit to a4tunado/piwik that referenced this issue Sep 20, 2014
refs matomo-org#6257 visitorUUID equal by default for each new Piwik.…
398b783 
…Tracker
@mattab
Copy link
Member

mattab commented Sep 21, 2014

Thanks for the pull request!

It looks good and it's a change we want to merge in. Do you think you could also add a test case for it? piwik.js is unit tested and you can run the Javascript tests at: /piwik/tests/javascript/

Maybe you can update your PR and add a test case for the constructor checking the uuid is kept. Cheers

@mattab mattab added this to the Piwik 2.7.0 milestone Sep 21, 2014
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 21, 2014
@mattab mattab modified the milestones: Piwik 2.8.0, Piwik 2.7.0 Sep 22, 2014
a4tunado pushed a commit to a4tunado/piwik that referenced this issue Sep 24, 2014
refs matomo-org#6257 Piwik.getVisitorId() function
7d672bf
a4tunado pushed a commit to a4tunado/piwik that referenced this issue Sep 24, 2014
refs matomo-org#6257 getVisitorId() unit tests
e059821
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 26, 2014
a4tunado pushed a commit to a4tunado/piwik that referenced this issue Sep 26, 2014
refs matomo-org#6257 removed getVisitorId() from Piwik API
47f6987
mattab pushed a commit that referenced this issue Sep 26, 2014
Merge pull request #6258 from a4tunado/6257
3396d9b 
refs #6257 visitorUUID equal by default for each new Piwik.Tracker
@mattab
Copy link
Member

mattab commented Oct 2, 2014

@a4tunado I can't see the pull request anymore, not sure how to proceed, could you let me know or recreate PR?

@mattab mattab modified the milestones: Piwik 2.8.0, Piwik 2.9.0 Oct 2, 2014
@a4tunado
Copy link
Author

a4tunado commented Oct 2, 2014

Looks like you've already merged it 3396d9b

@mattab
Copy link
Member

mattab commented Oct 2, 2014

Cheers!

@mattab mattab closed this as completed Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@a4tunado @mattab