Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify ViewDataTable so it uses report/dimension/segment metadata classes when possible #6253

Closed
diosmosis opened this issue Sep 19, 2014 · 3 comments
Closed

modify ViewDataTable so it uses report/dimension/segment metadata classes when possible #6253

diosmosis opened this issue Sep 19, 2014 · 3 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Long term

Comments

@diosmosis
Copy link
Member

As title. Instead of using certain ViewDataTable/Config properties (ie, Config::$subtable_controller_action), Report/Dimension/Segment classes should be used (ie, Report::actionToLoadSubtables).
@mattab
Copy link
Member

mattab commented Sep 20, 2014

+1 - it makes so much sense.

@mattab mattab added this to the Short term milestone Sep 20, 2014
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Sep 20, 2014
@diosmosis
Copy link
Member Author

Clarification on what I mean: Right now ViewDataTable/Config properties will be defaulted to Report/Dimension/Segment properties, but what I want to do is remove the Config properties all together and instead pass Report/Dimension/Segment metadata to client side code. Then dataTable.js will just use that data.

@mattab mattab modified the milestones: Mid term, Short term Dec 18, 2014
@mattab
Copy link
Member

mattab commented May 5, 2016

This will be done as part of the UI & Client side improvements project, where we slowly move logic from server side controllers towards client side controllers (AngularJS), and improving our HTTP APIs so that clients (eg. browser) can do everything with such APIs. Some work is already done in Piwik 3.0 branch, for more info see this issue #7131

@mattab mattab closed this as completed May 5, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
2 participants
@diosmosis @mattab