Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML scheduled report does not render in browser #6245

Closed
tsteur opened this issue Sep 18, 2014 · 3 comments
Closed

HTML scheduled report does not render in browser #6245

tsteur opened this issue Sep 18, 2014 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
Backlog (Help wan...

Comments

@tsteur
Copy link
Member

tsteur commented Sep 18, 2014

Problem is it sends the header text/xml.

Getting the error "error on line 4 at column 8: Opening and ending tag mismatch: meta line 0 and head". When fixing the not closed meta tag I am getting the next error "error on line 52 at column 27: Entity 'nbsp' not defined".

header should be text/html probably.

One should be able to reproduce it when clicking in scheduled reports on "download" or "send report now". Format should be HTML
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 18, 2014
@mattab
Copy link
Member

mattab commented Sep 19, 2014

Ok, this is maybe a regression from https://github.com/piwik/piwik/pull/6211/files as well

@mattab mattab added this to the Short term milestone Sep 19, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 19, 2014
mattab added a commit that referenced this issue Sep 19, 2014
@mattab
Refs #6245 work around issue for now by setting &format=csv|html in t…
60792cb 
…he link to download.

The issue is that this data returned by the method is going through the Api Renderer which then sets the content type header. Instead we should skip the API renderer somehow for these API methods that return data and set their own headers?
@mattab
Copy link
Member

mattab commented Sep 19, 2014

I'm closing after 60792cb which should fix it, though it's a workaround and there instead should be a way for data not to go through the ResponseBuilder that sends content type headers. (format=original didn't work as it set text/plain content type for added protection against xss)

@mattab mattab closed this as completed Sep 19, 2014
@tsteur
Copy link
Member Author

tsteur commented Sep 19, 2014

Maybe setting second parameter in overwrite would fix it for all kind of report renderer, even for third party plugins? https://github.com/piwik/piwik/blob/master/core/ReportRenderer.php#L178-178 Not sure, haven't tried it. But would not be a workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab