Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use php_uname() instead of shell_exec('uname') #6237

Closed
wants to merge 1 commit into from
Closed

use php_uname() instead of shell_exec('uname') #6237

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2014

This solution works on a host where otherwise I had problems when the archive job was started through cron. Can someone test this on synology if it also works there?
http://php.net/manual/en/function.php-uname.php

This solution works on a host where otherwise I had problems when the archive job was started through cron. Can someone test this on synology if it also works there?
http://php.net/manual/en/function.php-uname.php
@mattab
Copy link
Member

mattab commented Sep 19, 2014

Thanks for PR. According to http://forum.piwik.org/read.php?2,113613,page=1#msg-113739
php_uname will not return full string as in the shell.
What I propose is to do shell_exec first and if(empty()) then call php_uname();
which should make it work in cases? Cheers

@mattab mattab added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Bug For errors / faults / flaws / inconsistencies etc. labels Sep 19, 2014
@mattab mattab added this to the Piwik 2.7.0 milestone Sep 19, 2014
@mattab mattab closed this in 2133945 Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant