Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed unit test #6234

Closed
kylekatarnls opened this issue Sep 17, 2014 · 2 comments
Closed

Failed unit test #6234

kylekatarnls opened this issue Sep 17, 2014 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@kylekatarnls
Copy link
Contributor 

1) Test_Piwik_ServeStaticFile::test_firstAccessNoCompression
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'text/plain'
+'text/plain;charset=UTF-8'

text/plain;charset=UTF-8 is a text/plain content-type so I suggest to test it with ->assertContains()
kylekatarnls added a commit to kylekatarnls/piwik that referenced this issue Sep 17, 2014
@kylekatarnls
matomo-org#6234 Allow charset complement in content-type
6ee42c1 
Received text/plain;charset=UTF-8 should match with an expected text/plain
@kylekatarnls
Copy link
Contributor Author

This should fix the test:
#6235

mattab pushed a commit that referenced this issue Sep 17, 2014
Merge pull request #6235 from kylekatarnls/patch-4
3bf2f6f 
#6234 Allow charset complement in content-type
@mattab
Copy link
Member

mattab commented Sep 17, 2014

see Fix one unit test in PHP 5.6 allow charset complement in content-type #6235

@mattab mattab closed this as completed Sep 17, 2014
@mattab mattab added duplicate For issues that already existed in our issue tracker and were reported previously. Bug For errors / faults / flaws / inconsistencies etc. labels Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @kylekatarnls