Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getExpiresHeaderForFutureDay should be static #6232

Closed
kylekatarnls opened this issue Sep 16, 2014 · 1 comment
Closed

getExpiresHeaderForFutureDay should be static #6232

kylekatarnls opened this issue Sep 16, 2014 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@kylekatarnls
Copy link
Contributor

Piwik\ProxyHttp::getExpiresHeaderForFutureDay should be static as we can see:

private function getExpiresHeaderForFutureDay($expireFarFutureDays)
{
    return "Expires: " . gmdate('D, d M Y H:i:s', time() + 86400 * (int)$expireFarFutureDays) . ' GMT';
}

Called line 85 with self::getExpiresHeaderForFutureDay.
kylekatarnls added a commit to kylekatarnls/piwik that referenced this issue Sep 16, 2014
@kylekatarnls
matomo-org#6232 getExpiresHeaderForFutureDay should be static
d50cef5
kylekatarnls added a commit to kylekatarnls/piwik that referenced this issue Sep 16, 2014
@kylekatarnls
matomo-org#6232 getExpiresHeaderForFutureDay should be static
7917792
@kylekatarnls kylekatarnls mentioned this issue Sep 16, 2014
Merged
mattab pushed a commit that referenced this issue Sep 16, 2014
Merge pull request #6233 from kylekatarnls/patch-2
ddc4914 
#6232 getExpiresHeaderForFutureDay should be static
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 17, 2014
@mattab
Copy link
Member

mattab commented Sep 17, 2014

👍

@mattab mattab closed this as completed Sep 17, 2014
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @kylekatarnls