Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the plugin: Ip2Hostname? #6219

Closed
ThaDafinser opened this issue Sep 15, 2014 · 7 comments
Closed

Publish the plugin: Ip2Hostname? #6219

ThaDafinser opened this issue Sep 15, 2014 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@ThaDafinser
Copy link
Contributor

Hello,

i created a very easy plugin: Ip2Hostname https://gist.github.com/ThaDafinser/49fef1a7ad3fd1cf98dd
(no views currently, just log to database)

_My question_
Shall i publish it? Since it would log the complete hostname (if available) the information could be sensitive...?!

I use the information to find outdated enviroments: screen resolution/browser/OS

@ThaDafinser ThaDafinser changed the title Plugin: Ip2Hostname Publish the plugin: Ip2Hostname? Sep 15, 2014
@mattab
Copy link
Member

mattab commented Sep 17, 2014

Hi @ThaDafinser

Thanks for asking. By default the Provider plugin already provide this feature doesn't it? https://github.com/piwik/piwik/blob/master/plugins/Provider/Columns/Provider.php#L87-87

Maybe you use GeoIP Org in which case it would override the provider value. maybe that's why you needed to create this plugin?
cheers

@ThaDafinser
Copy link
Contributor Author

I saw that already @mattab .
But the provider plugin removes the first part.
So eg lvps83-169-36-100.dedicated.hosteurope.de gets to hosteurope.de

Most clients (real persons) wont have such an information. But i dont know how that is worldwide?

@mattab
Copy link
Member

mattab commented Sep 17, 2014

Good point I forgot this. Your plugin will definitely have value for people then! +1 Though Privacy wise it is important that you use the IP address after IP anonimisation (ie. it will respect user privacy choice and not diminish privacy).

Looking forward to seeing it on the Marketplace later!

@mattab mattab closed this as completed Sep 17, 2014
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Sep 17, 2014
@mattab
Copy link
Member

mattab commented Sep 17, 2014

@ThaDafinser maybe you can use the new way of writing dimensions? See eg. https://github.com/piwik/piwik/blob/master/plugins/Provider/Columns/Provider.php#L87-87

so instead of using the hook you create this new class. Let us know how it goes (it's new!). It's the future for definining new columns as the Add and Drop are automatic when plugin is enabled / disabled. A lot of benefit in reusing columns :-)

@ThaDafinser
Copy link
Contributor Author

@mattab sounds good with automaticall add/drop columns, but is that the correct link?

@mattab
Copy link
Member

mattab commented Sep 17, 2014

@ThaDafinser see also: http://developer.piwik.org/api-reference/Piwik/Columns/Dimension you can also check other other plugins/XX/ that have a directory Columns/*.php

@ThaDafinser
Copy link
Contributor Author

@mattab if i understand that correctly....that's awesome 😄

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

2 participants