New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimension columns should always be allowed to be NULL in the DB (and should default to NULL) #6207
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Comments
mattab
added
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
labels
Sep 14, 2014
Maybe you could list what current dimensions do not allow NULL? I guess there are no good cases for it but would good to see the list. In general +1, added to |
grepping for 'columnType\s_=._NOT NULL' results in:
|
fixed in #10492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Dimensions are information attached to tracked entity (visits, actions, conversions, whatever). Since they only add context, they are not vital to the entity themselves and thus they should be allowed to be NULL in the DB.
Main use case: will allow easier testing. Not allowing NULL values (and not defaulting to NULL), means dimensions have to be known and data has to be specified for them when inserting test data. This becomes more of a problem when you consider that the dimensions loaded depend on the plugins loaded. If a new dimension is created or new core plugin w/ dimension created, all plugin unit tests that insert data will break.
@mattab Please tell me your thoughts on this, I would like to make this change soon.
CC @tsteur
The text was updated successfully, but these errors were encountered: