New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of new Browser Reports by Language and Language code #6199
Conversation
Nice pull request and good shot at trying to keep tests green! Here is my feedback:
let me know if you need help with making build green, travis uploads all processed artifacts which you can download and put in expected/ folder in case it's slow to run tests locally. See https://github.com/piwik/piwik/blob/master/tests/README.md#build-artifacts as soon as you make those changes and build is green I'll be able to merge. Cheers! |
Ok, all tests are green. Could you look at this ? |
$metricsByLanguage->sumMetricsVisits($code, $row); | ||
$langCode = Common::extractLanguageCodeFromBrowserLanguage($row['label'], $languageCodes); | ||
$countryCode = Common::extractCountryCodeFromBrowserLanguage($row['label'], $countryCodes, $enableLanguageToCountryGuess = true); | ||
$label = $countryCode == 'xx' || $countryCode == $langCode ? $langCode : $langCode . '-' . $countryCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you deconstruct the if statement here: it will be easier to read 👍
Review
|
Implementation of new Browser Reports by Language and Language code fixes #6097
Kuddos @vox3r for this work. |
#6097