Let Segments define a callback to use for suggested values in segment editor #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use suggested values callback in getSuggestedValuesForSegment API method.
|
This looks like a small yet really useful and well done change.Cheers! |
mattab
pushed a commit
that referenced
this pull request
Sep 11, 2014
…lback Use callback instead of raw data for segment suggested values
mattab
added
the
Enhancement
mattab
changed the title
|
The goal was: simple as possible, but fully functional. Thanks for quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code add possibility to overwrite suggested values with your own data from callback. (for example some custom query or static suggested data)