Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User ID implementation #6169

Merged
merged 28 commits into from Sep 9, 2014
Merged

User ID implementation #6169

merged 28 commits into from Sep 9, 2014

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 9, 2014

This pull requests contains the implementation for User ID feature including Tracker API, JS and PHP Clients, new segment userId, displayed in Visitor Log and Visitor Profile, tests, and a new nb_users metric displayed in most APIs outputs.

Refs #6109 #3490 #6162

- new user_id field to contain the raw user id value
- new &uid= tracker api parameter
- add userId to Live API output
- added integration test
…is may fail the test with changes in Tracker.php
… and Last visits widget link/tooltip opening the Visitor profile
Conflicts:
	core/Version.php
	misc/package/build.sh
…s. Means "Active Users". Displayed in Visitors Overview, in metrics picker, in API response, in Metadata
…_* to also affect the nb_uniq_users metric processing over periods, + only show Users metrics when it's greater than zero, + fix more tests and renamed test suite to UserIdAndVisitorIdTest
and restore Transitions tests which I deleted by mistake earlier
…ome reason the column does appear by default but in the backwardsCompatibilityTest it does not appear there. Also had to manually activate and install plugins in the test case for some reason. Message was:

```
Exception: Failed to update database (errors or warnings found): Array
(
    [warnings] => Array
        (
        )

    [errors] => Array
        (
            [0] => /home/matt/dev/piwik-master/plugins/CustomAlerts/Updates/0.0.2.php:
Error trying to execute the query 'ALTER TABLE `alert` CHANGE `enable_mail` `email_me` BOOLEAN NOT NULL'.
The error was: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'piwik_tests.alert' doesn't exist
        )

    [coreError] =>
    [deactivatedPlugins] => Array
        (
            [0] => CustomAlerts
        )

)

```
mattab pushed a commit that referenced this pull request Sep 9, 2014
@mattab mattab merged commit c0511bb into master Sep 9, 2014
@mattab mattab added this to the Piwik 2.7.0 milestone Sep 9, 2014
@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants