Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy for plugin developers to use sub-tables of any level in their data plugin #6167

Open
mattab opened this issue Sep 8, 2014 · 0 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@mattab
Copy link
Member

mattab commented Sep 8, 2014

The goal of this issue is to make it easier to developers to manage data tables where rows can have nested sub-tables. In particular we may review how Sub-tables are implemented and the API proposed to platform developers. This can be broken down later by client side AngularJS improvements (new angularjs datatable?), and by core analytics platform PHP work. (each technology has its own set of challenges to solve before we can reach a state of beautiful sub tables APIs.)

Context
This feature of displaying data from sub-tables is available in common reports (Referrers > Websites, click on domain and you get all pages that sent you traffic for this website), and in Actions > Pages when you click a directory in the report it then open all pages within this Page URLs path.

The code is a bit convoluted and maybe awkward as it requires to use an idSubtable that sometimes makes things difficult. Instead maybe we could think of a simpler and better way in Piwik to manage tables with nested tables?

Use case

subtables

originating from this other comment #6097 (comment) a very nice use case for use of sub-tables of a single datatable.

Note: these sub-tables would be based off a single data table, "grouped by" language only to make visualisation better. (in other words, the server side does not implement idSubtable parameter.)

References
There are several opened issues about sub-tables:

Tasks

  • Identify how this problem was solved before by other tools and data libraries
  • Core platform: maybe the idSubtable could be changed to be instead the label of the row we want to get sub-level?
  • JS-AngularJS: make it possible to display sub-tables on any datatable (see Use case above)
  • TBD

let's discuss in the comments!

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: UI - UX (AngularJS twig less) labels Sep 8, 2014
@mattab mattab added this to the Mid term milestone Sep 8, 2014
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 9, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

1 participant