Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive tables for Piwik table reports #6159

Closed
mattab opened this issue Sep 8, 2014 · 8 comments
Closed

Responsive tables for Piwik table reports #6159

mattab opened this issue Sep 8, 2014 · 8 comments
Labels
answered For when a question was asked and we referred to forum or answered it. c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.

Comments

@mattab
Copy link
Member

mattab commented Sep 8, 2014

The goal of this issue is to implement Responsive tables in Piwik, to better account for the diversity of screen widths when using Piwik. For example the visible columns could automatically increase if there is more screen available.

Reference
Here is a great article that sum up the existing possibility for responsible table:
http://filamentgroup.com/lab/tablesaw.html

Solution 1 - Stack row:
1

Solution 2 - Toggle columns:
2

Solution 3 - Page columns:
3

Tasks

  • Discuss and prototype a good generic solution.
  • Test it:
    • on datatables in reports,
    • on two-column reports,
    • on widgets in dashboard.
  • Check edge cases: truncation, small screens, large screens
  • add screenshot tests testing for more screen widths (such as existing mobile use case screenshot in Make theme look great when used in Mobile browser #5029 )

Notes

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: UI - UX (AngularJS twig less) labels Sep 8, 2014
@mattab mattab added this to the Mid term milestone Sep 8, 2014
@tassoman
Copy link
Contributor

tassoman commented Sep 8, 2014

Well, responsiveness is cool 😎 but is going the opposite direction of accessibility, maybe we could save our souls using WAI-ARIA 👼

@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed c: UI - UX (AngularJS twig less) labels Oct 12, 2014
@mattab mattab added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Apr 30, 2015
@mattab
Copy link
Member Author

mattab commented May 27, 2016

@tsteur in Piwik 3 hopefully we will add a "scroll" feature to datatables so that our very wide tables with many columns (or a very long labels #6121) will be visible by scrolling to the right. Moving to 3.0.0 tentatively.

@mattab mattab modified the milestones: 3.0.0, Long term May 27, 2016
@tsteur
Copy link
Member

tsteur commented May 27, 2016

I assigned myself to #6121 but not to this one. As it won't be truly responsive :)

@username1290
Copy link

Can this one be closed too? The UI adapts to the available real estate.

@mattab
Copy link
Member Author

mattab commented Oct 23, 2017

Agreed it's much better now. Not sure if the issue is fully done though. What do you think @tsteur - should we leave this opened or rather create other tickets for specific issues?

@tassoman
Copy link
Contributor

I'd like to ask Mr @jdeyla about performing #a11y tests on 3.x branch ui

@tsteur
Copy link
Member

tsteur commented Oct 23, 2017

It is better now, although not fully responsive I reckon, and we could close the issue. I presume there is another issue to make row actions work on mobile phones?

@mattab
Copy link
Member Author

mattab commented Oct 24, 2017

I presume there is another issue to make row actions work on mobile phones?

According to quick testing now, the row actions are usable on Android (it was improved/fixed a few months ago)... or is there still a problem/something can be improved with row actions on mobile? @tsteur

Closing issue as the tables are "responsive enough" and quite usable.

@tassoman @jdeyla any a11y suggestion is welcome, please create a new issue with suggestion

@mattab mattab closed this as completed Oct 24, 2017
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

4 participants